Hello, On Tue, Sep 06, 2011 at 02:06:23PM +0400, Sergei Shtylyov wrote: > On 06-09-2011 8:09, Tejun Heo wrote: > > >ata_sff_data_xfer[32]() use pad area if the transfer size isn't > >multiple of transfer size; however, this area wasn't cleared and > >garbage data in pad area could be transferred to the device. Make > >sure the pad area is cleared. > > >Signed-off-by: Tejun Heo<tj@xxxxxxxxxx> > >Cc: Lei Ming<tom.leiming@xxxxxxxxx> > > And what's the problem with garbage data? Why it's worse than 0s? There were devices which puke on random garbage at the end of CDB and in general sending indeterministic garbage to external device is a bad idea. It increases chance of problems which can be difficult to reproduce and track down while gaining nothing. It really is a stupid thing to do. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html