On Tue, 06 Sep 2011 14:06:23 +0400 Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > Hello. > > On 06-09-2011 8:09, Tejun Heo wrote: > > > ata_sff_data_xfer[32]() use pad area if the transfer size isn't > > multiple of transfer size; however, this area wasn't cleared and > > garbage data in pad area could be transferred to the device. Make > > sure the pad area is cleared. > > > Signed-off-by: Tejun Heo<tj@xxxxxxxxxx> > > Cc: Lei Ming<tom.leiming@xxxxxxxxx> > > And what's the problem with garbage data? Why it's worse than 0s? It's potentially externally observable on things like an eSATA port so it probably should be cleared just as we do with network padding. For the CDB case we clear the rest of the CDB anyway I believe because some old PATA stuff used to freak if the padding wasn't zero. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
