Hello, Hannes. On Fri, Mar 04, 2011 at 09:55:01AM +0100, Hannes Reinecke wrote: > +static inline int ata_id_has_wwn(const u16 *id) > +{ > + if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000) > + return 0; > + return id[ATA_ID_CSF_DEFAULT] & (1 << 8); > +} Can you please make this return bool? Otherwise, Acked-by: Tejun Heo <tj@xxxxxxxxxx> Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html