On 03/04/2011 12:09 PM, Tejun Heo wrote:
Hello, Hannes. On Fri, Mar 04, 2011 at 09:55:01AM +0100, Hannes Reinecke wrote:+static inline int ata_id_has_wwn(const u16 *id) +{ + if ((id[ATA_ID_CSF_DEFAULT]& 0xC000) != 0x4000) + return 0; + return id[ATA_ID_CSF_DEFAULT]& (1<< 8); +}Can you please make this return bool? Otherwise,
And if you're highly motivated, a separate patch to update include/linux/ata.h to return bool for obvious ata_id_has_xxx functions would be nice too.
But yes, including WWN here is just fine. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
