On 03/04/2011 12:17 PM, Sergei Shtylyov wrote:
> Hello.
>
> On 04-03-2011 11:55, Hannes Reinecke wrote:
>
>> As per SAT-3 the WWN ID should be included in the VPD page 0x83
>> (device identification) emulation.
>
>> Signed-off-by: Hannes Reinecke<hare@xxxxxxx>
> [...]
>
>> diff --git a/include/linux/ata.h b/include/linux/ata.h
>> index 0c4929f..f62463e 100644
>> --- a/include/linux/ata.h
>> +++ b/include/linux/ata.h
> [...]
>> @@ -815,6 +817,13 @@ static inline int ata_id_has_unload(const u16 *id)
>> return 0;
>> }
>>
>> +static inline int ata_id_has_wwn(const u16 *id)
>> +{
>> + if ((id[ATA_ID_CSF_DEFAULT] & 0xC000) != 0x4000)
>> + return 0;
>> + return id[ATA_ID_CSF_DEFAULT] & (1 << 8);
>
> Could be compacted to:
>
> return (id[ATA_ID_CSF_DEFAULT] & 0xC100) == 0x4100;
>
Indeed.
Will be reposting the patch if one of the libata gods gives it's
overall assent.
Tejun?
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
