Re: [PATCH] ATA: Add FSL sata v2 controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 18-01-2011 14:43, Zang Roy-R61911 wrote:

On 18-01-2011 6:01, Zang Roy-R61911 wrote:

In FSL sata v2 block, the snoop bit of PRDT Word3 description
information is at bit28 instead of bit22.

This patch adds FSL sata v2 probe and resolve this difference.

Signed-off-by: Xulei<B33228@xxxxxxxxxxxxx>

[snip]

diff --git a/arch/powerpc/boot/dts/p1022ds.dts
b/arch/powerpc/boot/dts/p1022ds.dts
index 2bbecbb..9ad41dd 100644
--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts
@@ -475,14 +475,14 @@
    		};

    		sata@18000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
    			reg =<0x18000 0x1000>;
    			cell-index =<1>;
    			interrupts =<74 0x2>;
    		};

    		sata@19000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
    			reg =<0x19000 0x1000>;
    			cell-index =<2>;
    			interrupts =<41 0x2>;

      Please put this into the separate patch and push thru the PPC tree.

I agree to put to them to separate patches, but should we
pull in the separate patches to one candidate tree to make
the function work?

     I don't understand. What is "candidate tree"?

Powerpc or ide git repository for upstream to mainline.

   s/ide/libata/

It is odd that patches for one function in different trees.

The libata tree doesn't need to be concerned with PPC board specific device trees. Although it's up to the maintainer... just cross post the patch, and let the corresponding maintainers fogure it out.

Thanks.
Roy

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux