Re: [PATCH] ATA: Add FSL sata v2 controller support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 17-01-2011 10:10, Xulei wrote:

In FSL sata v2 block, the snoop bit of PRDT Word3 description
information is at bit28 instead of bit22.

This patch adds FSL sata v2 probe and resolve this difference.

Signed-off-by: Xulei <B33228@xxxxxxxxxxxxx>

   AFAIK, full name is required.

Signed-off-by: Roy Zang <tie-fei.zang@xxxxxxxxxxxxx>
[...]

diff --git a/arch/powerpc/boot/dts/p1022ds.dts b/arch/powerpc/boot/dts/p1022ds.dts
index 2bbecbb..9ad41dd 100644
--- a/arch/powerpc/boot/dts/p1022ds.dts
+++ b/arch/powerpc/boot/dts/p1022ds.dts
@@ -475,14 +475,14 @@
  		};

  		sata@18000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
  			reg =<0x18000 0x1000>;
  			cell-index =<1>;
  			interrupts =<74 0x2>;
  		};

  		sata@19000 {
-			compatible = "fsl,mpc8536-sata", "fsl,pq-sata";
+			compatible = "fsl,p1022-sata", "fsl,pq-sata-v2";
  			reg =<0x19000 0x1000>;
  			cell-index =<2>;
  			interrupts =<41 0x2>;

   Please put this into the separate patch and push thru the PPC tree.

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index b0214d0..a56399a 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
[...]
@@ -417,7 +420,8 @@ static void sata_fsl_qc_prep(struct ata_queued_cmd *qc)

  	if (qc->flags&  ATA_QCFLAG_DMAMAP)
  		num_prde = sata_fsl_fill_sg(qc, (void *)cd,
-					&ttl_dwords, cd_paddr);
+					&ttl_dwords, cd_paddr,
+					    host_priv->data_snoop);

   Please align these lines uniformly.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux