Re: [PATCH v2] ata: pata_at91.c bugfix for high master clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/13/2010 06:02 AM, Sergei Shtylyov wrote:
On 12-12-2010 22:02, Igor Plyatov wrote:
static const struct ata_timing initial_timing =
- {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 600, 0};
+ {XFER_PIO_0, 70, 290, 240, 600, 165, 150, 0, 600, 0};

BTW, you haven't described this in the changelog...

Here is just a typo fixed for the ata_timing structure. This typo does
not have influence on the driver operation, but I do not like to leave
such a negligible problem as it is.

You at least should have noted that in the changelog. And as the change
is unrelated to the other changes you're doing, it's a good practice to
put it into a separate patch.

Agreed...


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux