Re: [PATCH #upstream-fixes] ahci: fix module refcount breakage introduced by libahci split

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/21/2010 09:32 AM, Michael Tokarev wrote:
> 21.09.2010 11:25, Tejun Heo wrote:
>> libata depends on scsi_host_template for module reference counting and
>> sht's should be owned by each low level driver.  During libahci split,
>> the sht was left with libahci.ko leaving the actual low level drivers
>> not reference counted.  This made ahci and ahci_platform always
>> unloadable even while they're being actively used.
>>
>> Fix it by defining AHCI_SHT() macro in ahci.h and defining a sht for
>> each low level ahci driver.
>>
>> stable: only applicable to 2.6.35.
>>
>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
>> Reported-by: Michael Tokarev <mjt@xxxxxxxxxx>
>> Cc: stable@xxxxxxxxxx
>> ---
>> Michael, thanks a lot for spotting it and bearing with me.
> Um.  All thanks goes to Pedro Francisco please, not to me -
> I just verified your patch on my system, it was Pedro who spotted
> and reported this.  You may add my
> 
>  Tested-Off-By: Michael Tokarev <mjt@xxxxxxxxxx>
> 
> , but not Reported-by... please ;)

Oh, right.  Jeff, can you please adjust tags to

  Reported-by: Pedro Francisco <pedrogfrancisco@xxxxxxxxx>
  Tested-by: Michael Tokarev <mjt@xxxxxxxxxx>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux