>>>>> "hch" == Christoph Hellwig <hch@xxxxxx> writes: hch> I don't think we can simply break all existing setups with support hch> for earlier SBC drafts. I think we should use the TPU and TPWS hch> same bits if present and else fall back to our current heuristics. Originally my patch included support for "legacy" TP devices triggered by TPE=1 but no TP VPD page listed in page 0. I also supported the even older TP approach (WRITE SAME without the UNMAP bit, all zero payload). However, I talked to a few partners and everybody were going to add the TP VPD to their firmware builds right away. So I ripped out the compat stuff because I felt it was weird to have explicit support for an intermediate SBC3 release in there. How would you feel about a sysfs switch to "force" TP on for devices that don't report it correctly? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
