On Thu, Aug 19, 2010 at 11:49:01AM -0400, Martin K. Petersen wrote: > + if (sdkp->tpu && desc_count && lba_count) > + sdkp->unmap = 1; > + else if (!sdkp->tpws) { > + sd_printk(KERN_ERR, sdkp, "Thin provisioning is " \ > + "enabled but neither TPU, nor TPWS are " \ > + "set. Disabling discard!\n"); > + goto out; > + } > + I don't think we can simply break all existing setups with support for earlier SBC drafts. I think we should use the TPU and TPWS same bits if present and else fall back to our current heuristics. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html