Re: [PATCH 2/2] ahci EM message type auto detect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On 04/22/2010 12:16 PM, Harry Zhang wrote:
> +	/* em message type */
> +	EM_MSG_TYPE_LED		= (1 << 0), /* LED */
> +	EM_MSG_TYPE_SAFTE	= (1 << 1), /* SAF-TE */
> +	EM_MSG_TYPE_SES2	= (1 << 2), /* SES-2 */
> +	EM_MSG_TYPE_SGPIO	= (1 << 3), /* SGPIO */

Shouldn't the store/show methods be testing the above SGPIO flag?
Also, can you please move this patch before the other one?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux