On 12/01/2009 04:29 PM, Benjamin Herrenschmidt wrote: > On Tue, 2009-12-01 at 16:25 +0900, Tejun Heo wrote: >> On 12/01/2009 04:08 PM, Benjamin Herrenschmidt wrote: >>> In libata-sff, ata_sff_post_internal_cmd() directly calls ata_bmdma_stop() >>> instead of ap->ops->bmdma_stop(). This can be a problem for controllers >>> that use their own bmdma_stop for which the generic sff one isn't suitable >>> >>> Signed-off-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> >> >> Oh... that's a scary bug lurking around. Thanks for catching it. >> >> Acked-by: Tejun Heo <tj@xxxxxxxxxx> > > Feel free to pick that one up earlier if you want (ie for 2.6.32), as > long as we manage to get it in in 2.6.33 -before- I push powerpc-next to > Linus, I'm happy :-) (or we can have it in both trees). As nasty as the bug might be, given that we haven't had too much problem with that, I think it would be best to give it some time to be tested before releasing it to users. It causes behavior differences for all bmdma drivers which implement custom bmdma_stop. It's an apparent bug fix but well the nasty ones are always apparent bug fixes, right? :-) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
