(Shaohua Li cc'd) Hello, On 11/30/2009 11:22 AM, Benjamin Herrenschmidt wrote: > One quick nit tho, in libata-eh.c, in ata_eh_handle_port_suspend(), any > reason why you always call ata_acpi_set_state(ap, PMSG_SUSPEND) rather > than ata_acpi_set_state(ap, ap->pm_mesg) ? > > Not directly related to my pmac driver but it seems like it would cause > calls into ACPI suspend/resume code even when doing freeze/thaw for > hibernation which doesn't sound totally right to me ... or do I miss > something ? Indeed, it looks like it will power down the IDE port over freeze. Shaohua, this is added by commit bd3adca52bc43b72c75db3e4c7809d47923b154c. Skipping power down on freeze is probably the right thing to do? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
