Hi there ! So I (finally !) resumed work on pata_macio.c to replace ide/pmac.c :-) I've started looking at the suspend/resume stuff. It looks like most of it just comes for free thanks to libata, yay ! :-) One quick nit tho, in libata-eh.c, in ata_eh_handle_port_suspend(), any reason why you always call ata_acpi_set_state(ap, PMSG_SUSPEND) rather than ata_acpi_set_state(ap, ap->pm_mesg) ? Not directly related to my pmac driver but it seems like it would cause calls into ACPI suspend/resume code even when doing freeze/thaw for hibernation which doesn't sound totally right to me ... or do I miss something ? Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
