> Looks like the only libata driver that currently does LED blinking is > ahci (for external enclosures) and it's just handled there using > qc_issue plus a timer. Most drivers don't need this and given that you > need to do it only for specific devices and only your driver has that > knowledge, I don't see much problem with just sticking the LED trigger > call into your qc_issue or something similar. No sense in trying to make > something generic if it's not generic.. Ok, thanks. Will stick it in pata_macio for the internal hard disk(s) only. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html