> Do you really find such tidy patch hard to review? When doing it at speed - yes. > /* Set UDMA unless device is not UDMA capable */ > - if (udma_type && t.udma) { > - u8 cable80_status; > + if (udma_type) { > + u8 udma_etc; Ok that makes sense - we in fact could hit this case on a failure changedown from UDMA to PIO. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html