> /* Set UDMA unless device is not UDMA capable */ > - if (udma_type && t.udma) { > - u8 cable80_status; > + if (udma_type) { > + u8 udma_etc; This seems odd the original test is that we are a udma controller and have a udma timing specified. Otherwise there is no point doing any work. The rest seems to be gratuitious register renaming and makes the patches hard to review. Please split this sort of stuff up. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html