On Wednesday 25 November 2009 06:25:41 pm Alan Cox wrote: > > Rename 'idetm_port' and 'idetm_data' variables to 'master_port' > > and 'master_data' respectively to match register naming used in > > efar_set_dma_mode() and in ata_piix.c. > > Probably better to do the reverse to match the docs ? It just matches ata_piix.c code currently. > > - u16 idetm_data; > > + u8 master_port = ap->port_no ? 0x42 : 0x40; > > + u16 master_data; > > Please don't drop undocumented type changes in. And btw it uses unsigned Oh, I forgot to document it in this patch. Others should have it documented. [ Will fix later. ] > int here as all over the kernel because it produced better code in many > cases Better code is smaller code in this situation and this is clearly minor issue anyway (since the code is not performance critical having cleaner code wins over). > These patches seem to spend a lot of time renaming everything in drivers It just prepares the code for unification of code programming PIO and MWDMA methods, see patch #18. -- Bartlomiej Zolnierkiewicz -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
