> Rename 'idetm_port' and 'idetm_data' variables to 'master_port' > and 'master_data' respectively to match register naming used in > efar_set_dma_mode() and in ata_piix.c. Probably better to do the reverse to match the docs ? > - u16 idetm_data; > + u8 master_port = ap->port_no ? 0x42 : 0x40; > + u16 master_data; Please don't drop undocumented type changes in. And btw it uses unsigned int here as all over the kernel because it produced better code in many cases These patches seem to spend a lot of time renaming everything in drivers which is usually pointless churn (eg the atp grand renaming), but the bug fixes all look good -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
