Re: ATA: Make CS5536 PATA driver use 32-bit BM DMA template instead of 16-bit.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Nov 2009 12:35:50 +0100
Thierry Vignaud <tvignaud@xxxxxxxxxxxx> wrote:

> Jeff Garzik <jgarzik@xxxxxxxxx> writes:
> 
> > > diff --git a/drivers/ata/pata_cs5536.c b/drivers/ata/pata_cs5536.c
> > > index 88a7933..0898213 100644
> > > --- a/drivers/ata/pata_cs5536.c
> > > +++ b/drivers/ata/pata_cs5536.c
> > > @@ -232,7 +232,7 @@ static struct scsi_host_template cs5536_sht = {
> > >   };
> > >
> > >   static struct ata_port_operations cs5536_port_ops = {
> > > -	.inherits		=&ata_bmdma_port_ops,
> > > +	.inherits		=&ata_bmdma32_port_ops,
> > >   	.cable_detect		= cs5536_cable_detect,
> > >   	.set_piomode		= cs5536_set_piomode,
> > >   	.set_dmamode		= cs5536_set_dmamode,
> >
> > applied
> 
> Why not rename ata_bmdma_port_ops as ata_bmdma_port_ops16 for
> consistency?

Because 16bit is the normal default for ATA BMDMA, and because its a ton
of unneccessary churn ?
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux