On Sun, 15 Nov 2009 17:05:51 +0900 Tejun Heo <tj@xxxxxxxxxx> wrote: > Most of logic seems to belong to libata generic part rather than in > ahci itself. Wouldn't it be better to implement the thing as generic > libata feature which ahci uses? maybe. AHCI is the only one using it then (2 years ago there was discussion about having others do alpm as well but.. well nothing has happened). Doing "most" in libata means that at best you end up with stuff no longer local and static, and at worst that you get a bunch of new function pointers via method tables going around... for something only one driver is using (with no sight of other users). If there were going to be more users... I'd absolutely agree with you. But for only 1 user... I tend to prefer simplicity ;) -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
