Re: [PATCH #upstream, v2] ahci: Implement SATA AHCI FIS-based switching support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Huang, Shane wrote:
> Yes, it can leave pp->fbs_enabled out of sync, but just removing the
> check and setting the bit anyway will still lead to the print of this
> message for each SATA port:
> ahci 0000:00:11.0: FBS is disabled.
> 
> So I would suggest to keep the check and also add the sync of
> pp->fbs_enabled, which can also save the restart of DMA engine:

Yeap, sure.  But in general, it doesn't really matter whether the DMA
engine is started or restarted a few times during intialization.  Just
do whatever is safe and looks clean.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux