On Thursday, May 07, 2009 4:33 PM, João Ramos wrote: >>>> Yeah, that makes sense. Keeps the driver nice and clean that way >>>> too. The ep93xx_ide_on_gpio function for core.c should be posted >>>> as a separate patch though. >>>> >>>> >>> I agree. Actually that patch needs to go in now so that the port >>> E/F/G pins will work for normal GPIO. The syscon register defaults >>> at reset with the bits cleared so the boot state has them set for >>> IDE mode. That drove me nuts for quite a while... >>> >>> If wanted I will put together the necessary patch for this. >>> >> >> That would be good. I think that we should default all of the pins to >> gpio mode on boot, and then drivers should call into core.c to put pins >> in alternative function mode where necessary. >> > > Hartley, will you handle this then, or do you want me to submit a > separate patch for the renewed 'ep93xx_ide_on_gpio' function? > I can do this and test it already with the IDE patch to see if it's OK. I just posted the necessary patch. Please test that with your IDE patch. Thanks, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
