On Thursday, May 07, 2009 2:36 AM, João Ramos wrote:
>>>
>>> +
>>> +/*
>>> + * EP93xx IDE PIO low-level hardware initialization routine
>>> + */
>>> +static void ep93xx_ide_init_hwif(ide_hwif_t *hwif)
>>> +{
>>> + unsigned long base = hwif->config_data;
>>> +
>>> + /* enforce reset state */
>>> + ep93xx_ide_clean_regs(base);
>>> +
>>> + /* set gpio port E, G and H for IDE */
>>> + ep93xx_ide_on_gpio(1);
>>
>> Shouldn't this be done in the platform code instead?
>
> The idea is to make this driver loadable, as suggested earlier by
> Ryan and Hartley.
> The IDE pins are initially (and by default) set to GPIO function.
> If the IDE driver is registered, through specific platform code or
> by loading the module at runtime, then the IDE driver cares to
> configure the IDE pins for IDE function, returning them to GPIO
> function once the driver is unloaded.
>
> I think this is the approach desired by the EP93xx maintainers,
> correct? (Ryan? Hartley?)
The pins should default to gpio mode and only be set to IDE when this
driver is used.
If the IDE group objects to having the ep93xx_ide_on_gpio() call in
the driver it can be moved to the platform code. I assume if a user
has selected this driver they are not planning on using the pins for
gpio so when the driver is registered the pins could be put into IDE
mode at that time. The drawback is when the driver is a module the
pins will still be unavailable for gpio when the driver is not loaded.
>> Since this is not a hotplug driver, you can save some memory on
>> making ep93xx_ide_probe() __init -- using platform_driver_probe() here
>> instead of platform_driver_register() and *not* initializing the
>> 'probe' field of the 'struct platform_driver'.
>
> I think Ryan and Hartley would like this driver to be
> loadable/unloadable at runtime, as I pointed out earlier in this mail.
> I can make the fixes about this, ensuring Ryan and Hartley will both
> agree to them.
Ryan might have a comment on this. My platform does not use IDE at
this time.
Regards,
Hartley
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
