On Sun, May 03, 2009 at 06:02:51PM +0300, Boaz Harrosh wrote: > I agree with Hugh. The allocation is done at, too-low in the food chain. > (And that free of buffer at upper layer allocated by lower layer). > > I think you need to separate the: "does lld need buffer, what size" > from the "here is buffer prepare", so upper layer that can sleep does > sleep. So you want two function pointers in the request queue relating to discard? > In all other buffer needing operations the allocation is done before > submission of request, No? It's not true for the flush request (the example I quoted). Obviously, the solution adopted here by IDE is Bad and Wrong ... -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html