On Thursday 23 April 2009 00:29:23 David Brownell wrote: > On Wednesday 22 April 2009, Bartlomiej Zolnierkiewicz wrote: > > > > > By the way ... what about the first patch, > > > which removed accesses to all those non-existent > > > registers and bitfields? > > > > I didn't see any discussion on it and it looked less urgent / more risky > > (it is not uncommon for documentation to lack some data) than patch #2. > > It's uncommon for TI's documentation to be that far off, > for that long, though. "Lacking" docs for 50% of the > registers, for several years ... doesn't make sense. > > The current reset handling is clearly broken: the docs > are quite explicit that the controller doesn't drive the > reset signal, it's got to be done through a GPIO. The > board designs match that part of the docs. The code is > thus contrary to *all* other documentation. > > Early DaVinci drivers sometimes exhibited a flagrant > disregard for chip documentation. This driver is from > about that era. Maybe it started from prototypes using > the a different controller design, for example. > > > > Should it also go upstream for 2.6.30? > > I can't say either patch would be urgent for 2.6.30, > but of course it's good that bugfixes merge ASAP. > > Since we're only at RC3, I'd be inclined to push both > up right now. If we were at RC6 or so, I'd hold off > till the next merge window. Thanks for the detailed explanation. I applied the patch to ide-2.6.git/for-linus. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
