Hello, I wrote:
Add support for the CompactFlash specific PIO modes 5/6 and MWDMA modes 3/4. Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> --- Did two changes after Bart's review: - fixed wrong mask in ide_config_drive_speed(); - clarified comment in ide_pio_cycle_time(). This patch is against the current pata-2.6 series. Since there were no PIO5 capable hard drives produced and you also need 66 MHz input clock to actually get the difference WRT the setup timing programmed, I decided to simply replace the old non-standard PIO mode 5 timings with CFA specified ones. Phew, hopefully I haven't overlooked anything -- quite a lot had to be changed. Stanislaw, please give it a try -- I don't have any CF hardware now.
[...]
Index: linux-2.6/drivers/ide/ide-iops.c =================================================================== --- linux-2.6.orig/drivers/ide/ide-iops.c +++ linux-2.6/drivers/ide/ide-iops.c @@ -389,6 +389,8 @@ int ide_config_drive_speed(ide_drive_t * id[ATA_ID_UDMA_MODES] &= ~0xFF00; id[ATA_ID_MWDMA_MODES] &= ~0x0F00; id[ATA_ID_SWDMA_MODES] &= ~0x0F00; + if (ata_id_is_cfa(id)) + id[ATA_ID_CFA_MODES] &= ~0x0FC0;
Oops, won't this fragment clear the current DMA mode when setting PIO mode (and so vice versa for CF)?
MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
