Tejun Heo wrote:
Mark Lord wrote:
..
+ /* Enable message-switched interrupts, if requested */
+ if (msi && 0 == pci_enable_msi(pdev))
+ hpriv->hp_flags |= MV_HP_FLAG_MSI;
I just don't like CONSTANT OP EXPRESSION construct.
..
Heh.. Myself, I would normally just write it this way:
if (msi && !pci_enable_msi(pdev))
But the "coding correctness police" might point out that
it reads funny (negatives and all that).
But whatever way Jeff likes it, really.
-ml
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
