Hello, Mark. Mark Lord wrote: > Enable reliable use of Message-Signaled Interrupts (MSI) in sata_mv > by masking further chip interrupts within the main interrupt handler. > > Based upon a suggestion by Grant Grundler. > MSI is working reliably in all of my test systems here now. > > Signed-off-by: Mark Lord <mlord@xxxxxxxxx> Generally looks good, but... > + /* Enable message-switched interrupts, if requested */ > + if (msi && 0 == pci_enable_msi(pdev)) > + hpriv->hp_flags |= MV_HP_FLAG_MSI; I just don't like CONSTANT OP EXPRESSION construct. The only possible upside it has is that it would make the compiler fail if '=' is used instead of '==' but compiler has been smart enough to whine about LVALUE = EXPRESSION for a very long time now. How about plain !pci_enable_msi(pdev) or pci_enable_msi(pdev) == 0? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
