Hello, Joseph.
JosephChan@xxxxxxxxxx wrote:
>> Also, you can just bypass whole southbridge thing. Add
>> another flag, say, VIA_IDFLAG_IGN_SOUTH or something and just
>> skip the whole thing if the flags is set.
>>
>
> This is our next goal for this. :)
:-)
> @@ -97,8 +101,14 @@
> u8 rev_max;
> u16 flags;
> } via_isa_bridges[] = {
> + { "vtxxxx", PCI_DEVICE_ID_VIA_ANON, 0x00, 0x2f, VIA_UDMA_133 |
> + VIA_BAD_AST },
More usual line breaking / indenting style would be...
{ "vtxxxx", PCI_DEVICE_ID_VIA_ANON, 0x00, 0x2f,
VIA_UDMA_133 | VIA_BAD_AST },
> @@ -460,6 +470,7 @@
> static int printed_version;
> u8 enable;
> u32 timing;
> + unsigned long flags = id->driver_data;
> int rc;
>
> if (!printed_version++)
> @@ -469,6 +480,9 @@
> if (rc)
> return rc;
>
> + if (flags & VIA_IDFLAG_SINGLE)
> + ppi[1] = &ata_dummy_port_info;
> +
Yay.
> @@ -483,10 +497,10 @@
> }
>
> if (!config->id) {
> - printk(KERN_WARNING "via: Unknown VIA SouthBridge, disabling.\n");
> - return -ENODEV;
> - }
> - pci_dev_put(isa);
> + printk(KERN_WARNING "via: Unknown VIA SouthBridge.\n");
> + config = via_isa_bridges;
Heh.. a bit confusing. Can you please put the wildcard entry at the
end of the list and make the loop condition
for (config = via_isa_bridges; config->id != PCI_DEVICE_ID_VIA_ANON; config++)
That way, you won't need any special handling and just use "UNKNOWN"
as the name of the wildcard entry.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
