On Mon, Jan 05 2009, Bartlomiej Zolnierkiewicz wrote: > On Monday 05 January 2009, Jens Axboe wrote: > > On Mon, Jan 05 2009, Bartlomiej Zolnierkiewicz wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@xxxxxxxxx> > > > Subject: [PATCH] block: export SSD/non-rotational queue flag through sysfs > > > > > > For some devices (i.e. CFA ATA) we can't reliably detect whether > > > the device is of rotational or non-rotational type so we need to > > > leave the final decision about this setting to the user-space. > > > > I agree with that, was actually planning on doing that myself. > > > > > @@ -146,8 +167,8 @@ static ssize_t queue_nomerges_store(stru > > > queue_flag_set(QUEUE_FLAG_NOMERGES, q); > > > else > > > queue_flag_clear(QUEUE_FLAG_NOMERGES, q); > > > - > > > spin_unlock_irq(q->queue_lock); > > > + > > > return ret; > > > } > > > > > > > Hmm? > > This is just a "bonus". :) I typically prefer a line in-between, but apparently blk-sysfs uses the other style, so it's good to at least be consistent locally :-) I've applied the updated patch, thanks! -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
