Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 29 May 2008 10:45:18 +0900,
Tejun Heo wrote:
> 
> With the patch applied, control should never reach either of the above
> two lines.  Can you please double check?

I applied the following patch to check where the booting stops at


--- drivers/ata/ata_piix.c.orig	2008-05-29 12:26:18.000000000 +0900
+++ drivers/ata/ata_piix.c	2008-05-29 12:20:19.000000000 +0900
@@ -251,6 +251,7 @@
 	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* Mobile SATA Controller IDE (ICH8M), Apple */
 	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
+	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
 	/* SATA Controller IDE (ICH9) */
 	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
 	/* SATA Controller IDE (ICH9) */
@@ -526,7 +527,7 @@
 
 	[ich8m_apple_sata] =
 	{
-		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
+		.flags		= PIIX_SATA_FLAGS,
 		.pio_mask	= 0x1f,	/* pio0-4 */
 		.mwdma_mask	= 0x07, /* mwdma0-2 */
 		.udma_mask	= ATA_UDMA6,
@@ -1360,6 +1361,8 @@
 	if (!(host->ports[0]->flags & PIIX_FLAG_SIDPR))
 		return;
 
+dev_printk(KERN_INFO, &pdev->dev, "PASSED: checking PIIX_FLAG_SIDPR\n");
+
 	if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
 	    pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
 		return;
@@ -1375,6 +1378,8 @@
 	 */
 	scontrol = piix_sidpr_read(dev0, SCR_CONTROL);
 
+dev_printk(KERN_INFO, &pdev->dev, "PASSED: piix_sidpr_read(dev0, SCR_CONTROL)\n");
+
 	/* if IPM is already 3, SCR access is probably working.  Don't
 	 * un-inhibit power save modes as BIOS might have inhibited
 	 * them for a reason.


Then I rebooted without connecting the AC adapter, and the booting
process suspends after the following messages:


  (... snip ...)
  ata_piix 0000:00:1f.2: version 2.12
  ACPI: PCI Interrupt 0000:00:1f.2[B] -> GSI 18 (level, low) -> IRQ 18
  ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ]
  ata_piix 0000:00:1f.2: PASSED: checking PIIX_FLAG_SIDPR


Waited for about a minute, but the booting still keep suspending.

Once I plug the AC adapter again, booting continues with such messages as:


  ata_piix 0000:00:1f.2: PASSED: piix_sidpr_read(dev0, SCR_CONTROL)
  ACPI: EC: missing confirmations, switch off interrupt mode.
  ata_piix 0000:00:1f.2: SCR access via SIDPR is available but doesn't work
  PCI: Setting latency timer of device 0000:00:1f.2 to 64
  Clocksource tsc unstable (delta = -60927459992 ns)
  scsi0 : ata_piix
  scsi1 : ata_piix
  ata1: SATA max UDMA/133 cmd 0x60f8 ctl 0x611c bmdma 0x6020 irq 18
  ata2: SATA max UDMA/133 cmd 0x60f0 ctl 0x6118 bmdma 0x6028 irq 18
  ata1.00: ATA-8: Hitachi HTS542516K9SA00, BBCAC3GP, max UDMA/133
  ata1.00: 312581808 sectors, multi 16: LBA48 NCQ (depth 0/32)
  ata1.00: configured for UDMA/133
  scsi 0:0:0:0: Direct-Access     ATA      Hitachi HTS54251 BBCA PQ: 0 ANSI: 5
  sd 0:0:0:0: [sda] 312581808 512-byte hardware sectors (160042 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
  sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
  sd 0:0:0:0: [sda] 312581808 512-byte hardware sectors (160042 MB)
  sd 0:0:0:0: [sda] Write Protect is off
  sd 0:0:0:0: [sda] Mode Sense: 00 3a 00 00
  sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA
   sda: sda1 sda2 sda3 sda4
  sd 0:0:0:0: [sda] Attached SCSI disk
  (... snip ...)

--
Kohji
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux