Re: ata_piix on MacBook4,1: fail to startup in a certain situation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 29 May 2008 09:23:30 +0900,
Tejun Heo wrote:
> 
> Hmmm.. That really doesn't make much sense.  Can you please try the
> attached one just in case?

Still no luck - I couldn't see any progress even with this patch.
Booting still stops during either of the followings:

        if (pci_resource_start(pdev, PIIX_SIDPR_BAR) == 0 ||
            pci_resource_len(pdev, PIIX_SIDPR_BAR) != PIIX_SIDPR_LEN)
                return;

or

scontrol = piix_sidpr_read(dev0, SCR_CONTROL);

Once the AC Adapter is plugged in, booting continues fine.

--
Kohji

> [2 ata_piix-apple-1.patch <text/x-patch (7bit)>]
> diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c
> index a9027b8..6c2e907 100644
> --- a/drivers/ata/ata_piix.c
> +++ b/drivers/ata/ata_piix.c
> @@ -251,6 +251,7 @@ static const struct pci_device_id piix_pci_tbl[] = {
>  	{ 0x8086, 0x2828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* Mobile SATA Controller IDE (ICH8M), Apple */
>  	{ 0x8086, 0x2828, 0x106b, 0x00a0, 0, 0, ich8m_apple_sata },
> +	{ 0x8086, 0x2828, 0x106b, 0x00a1, 0, 0, ich8m_apple_sata },
>  	/* SATA Controller IDE (ICH9) */
>  	{ 0x8086, 0x2920, PCI_ANY_ID, PCI_ANY_ID, 0, 0, ich8_sata },
>  	/* SATA Controller IDE (ICH9) */
> @@ -526,7 +527,7 @@ static struct ata_port_info piix_port_info[] = {
>  
>  	[ich8m_apple_sata] =
>  	{
> -		.flags		= PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR,
> +		.flags		= PIIX_SATA_FLAGS,
>  		.pio_mask	= 0x1f,	/* pio0-4 */
>  		.mwdma_mask	= 0x07, /* mwdma0-2 */
>  		.udma_mask	= ATA_UDMA6,
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux