On Tuesday 22 April 2008, James Courtier-Dutton wrote: > Sergei Shtylyov wrote: > > > > /* return 1 if Device INTR asserted */ > > pci_read_config_byte(dev, addr, &dma_altstat); > > if (dma_altstat & 8) > > - return 0; //return 1; > > + return 0; /* return 1; */ > > + > > return 0; > > } > > > > > This bit of code looks strange. > The comment says return 1, but the return has been commented to return 0. > But, if we return 0, why bother with the if test anyway? Seems like we should remove this test (and the similar one in siimage_mmio_dma_test_irq) for now? Care to send a patch? Thanks, Bart -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
