Grant Grundler wrote:
I think you can associate any names you want with whatever the
non-public documentation is calling the registers by adding a comment
in the header files where the bit masks and register offsets are defined.
Or vice versa. Which ever way works for you.
I prefer to use the non-public register names in the code only because it
will be easier for Marvell engineers to participate in _maintaining_
this driver. I think getting involved with open source developement
is a good career developement experience. And the device drivers for
"obsolete" HW allows them to take more risks/make mistakes
without getting into serious trouble with the company.
The trouble, though, comes with following that logic in every driver,
making the collective body less accessible to anyone not _intimately_
tied into the hardware _and_ possessing NDA'd docs.
Further, it is obvious with _most_ drivers in Linux that engineers at
the hardware vendor do _not_ participate in maintaining drivers for
their older hardware, so I also wish to be careful and avoid punishing
the majority to help a minority.
I put a significant value in having more-readable code like
status = mr32(IRQ_STAT); /* read IRQ status from PPB */
rather than
status = READ_REG(ICR5PPB); /* read IRQ status from PPB */
because the casual reader is more likely to understand the first
example, even though it deviates from the string of line noise some
engineer writing Verilog at 4:00am decided was a good register name.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
