Interesting - I was just looking at this code this morning - and comparing with the reference driver Marvell has given us - this was one of the differences I was looking at because with this new driver and the old reference driver we were having performance problems due to vibrations or something that is causing the disk write performance to go very low (<5Mbytes/second)... I'd be very interested what Mark has to say about this - he just made some update to the driver - perhaps he has updated these values... t -----Original Message----- From: linux-ide-owner@xxxxxxxxxxxxxxx [mailto:linux-ide-owner@xxxxxxxxxxxxxxx] On Behalf Of Sylver Bruneau Sent: Monday, April 21, 2008 8:43 AM To: linux-ide@xxxxxxxxxxxxxxx Cc: jeff@xxxxxxxxxx Subject: sata_mv errata function Hello, during my analysis of some recent patches [1] from Marvell for several ARM based (88f5182 & 88f5281) NAS devices, i've found that some errata stuff are a little bit different from what is done in sata_mv.c mainline code. I don't know if there is a reason for the code not to be the same, but I think that it could be useful to bring that to you. Here are the facts ... First, the fix value for phyMode 3 is a little bit different : while sata_mv.c is applying a tmp &= ~0x7F800000; the patch from Marvell (check _fixPhyParams function in arch/arm/mach-feroceon/Board /SATA/CoreDriver/mvSata.c file) is applying a regVal &= ~0x7F900000; The fix value for phyMode 4 is also different for GEN IIE (6042 & 7042) devices : in Marvell patch, there is an additional fix for this case (where nothing seems to be done for this in sata_mv.c) : /* phy mode 4 register of Gen IIE devices has some restriction */ if (pAdapter->sataAdapterGeneration >= MV_SATA_GEN_IIE) { phyMode4Value &= ~0x5DE3FFFC; phyMode4Value |= MV_BIT2; } I understand that what is done in this function is not well documented, but as it's what is done by Marvell in their patches, do you think that it should be merged in sata_mv.c ? If so, I will post a proper patch to add this ! Thanks, Sylver Bruneau [1] Marvell/QNAP patch for the TS-409 NAS (88f5281 based + PCIe 88SX7042 SATA controller) http://qnap.free.fr/kernel/stock/linux-2.6.21.1.patch -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
