Sylver Bruneau wrote:
Hello,
during my analysis of some recent patches [1] from Marvell for several
ARM based (88f5182 & 88f5281) NAS devices, i've found that some
errata stuff are a little bit different from what is done in sata_mv.c
mainline code.
I don't know if there is a reason for the code not to be the same, but
I think that it could be useful to bring that to you.
Here are the facts ...
First, the fix value for phyMode 3 is a little bit different :
while sata_mv.c is applying a
tmp &= ~0x7F800000;
the patch from Marvell (check _fixPhyParams function in
arch/arm/mach-feroceon/Board
/SATA/CoreDriver/mvSata.c file) is applying a
regVal &= ~0x7F900000;
The fix value for phyMode 4 is also different for GEN IIE (6042 &
7042) devices :
in Marvell patch, there is an additional fix for this case (where nothing
seems to be done for this in sata_mv.c) :
/* phy mode 4 register of Gen IIE devices has some restriction */
if (pAdapter->sataAdapterGeneration >= MV_SATA_GEN_IIE)
{
phyMode4Value &= ~0x5DE3FFFC;
phyMode4Value |= MV_BIT2;
}
I understand that what is done in this function is not well documented,
but as it's what is done by Marvell in their patches, do you think that it
should be merged in sata_mv.c ?
If so, I will post a proper patch to add this !
..
Thanks, Sylver.
I am currently working on sata_mv on behalf of Marvell,
and a full errata overhaul is in the works for the next
2-3 weeks here. So those bits will get fixed by me as
part of this effort.
But I will keep your description above in my inbox as a reminder
to double-check those specific items, just in case it differs from
the detailed errata information Marvell has provided to me (under NDA).
Thanks again.
Mark
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
