Tejun Heo írta:
Robert Hancock wrote:
Tejun Heo wrote:
Zoltan Boszormenyi wrote:
Tejun Heo írta:
akpm@xxxxxxxxxxxxxxxxxxxx wrote:
From: Zoltan Boszormenyi <zboszor@xxxxxxxxxx>
unchangelogged patch.
Signed-off-by: Zoltan Boszormenyi <zboszor@xxxxxxxxxx>
Cc: Robert Hancock <hancockr@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Nacked-by: Tejun Heo <htejun@xxxxxxxxx>
Sorry, there are remaining issues to resolve before enabling ADMA
by default.
Sorry, this is NOT ADMA. SWNCQ is completely independent from ADMA.
Heh, right. Sorry about that. I disabled ADMA on the distro I work
for and somehow ADMA was disabled on mainline too. :-)
Robert, is SWNCQ safe to turn on by default? I personally think
it's better to prefer safety over performance or optional features
and given the history of NCQ support on nv satas, I feel a bit more
cautious.
Maybe we can enable SWNCQ on -mm and devel branches and disable it
late in release cycle for 2.6.26 for a trial?
I haven't seen any problem reports, but with it disabled by default
most people haven't tried it. The only way to really know is to try
turning it on by default and see what shakes out.
I'd vote to enable it by default in -mm and 2.6.26-rc and see what
happens.
Alright, Zoltan can you please repost w/ commit message fixed and
comment stating /* FIXME: for testing during blah blah */ added?
You mean like this?
Enable SWNCQ by default for testing in 2.6.26-rcX[-mm] and
Signed-off-by: Zoltan Boszormenyi <zboszor@xxxxxxxxxx>
Cc: Robert Hancock <hancockr@xxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
drivers/ata/sata_nv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -puN drivers/ata/sata_nv.c~ata-swncq-should-be-enabled-by-default drivers/ata/sata_nv.c
--- a/drivers/ata/sata_nv.c~ata-swncq-should-be-enabled-by-default
+++ a/drivers/ata/sata_nv.c
@@ -532,7 +532,7 @@ MODULE_DEVICE_TABLE(pci, nv_pci_tbl);
MODULE_VERSION(DRV_VERSION);
static int adma_enabled = 1;
-static int swncq_enabled;
+static int swncq_enabled = 1; /* FIXME: for testing during 2.6.26-rcX[-mmY] */
static void nv_adma_register_mode(struct ata_port *ap)
{
@@ -2485,5 +2485,5 @@ module_exit(nv_exit);
module_param_named(adma, adma_enabled, bool, 0444);
MODULE_PARM_DESC(adma, "Enable use of ADMA (Default: true)");
module_param_named(swncq, swncq_enabled, bool, 0444);
-MODULE_PARM_DESC(swncq, "Enable use of SWNCQ (Default: false)");
+MODULE_PARM_DESC(swncq, "Enable use of SWNCQ (Default: true)");
