Re: [PATCHSET #upstream] libata: improve FLUSH error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, Andi.

Andi Kleen wrote:
Mark Lord <liml@xxxxxx> writes:
Really, the entire flush + retries etc.. should never, ever, be
permitted to take more than XX seconds total.  Not 60 seconds per
retry, but XX seconds total for the original command + however many
retries we can fit in there.

I fully agree. Also please make that user limit settable use
module_param too, not only sysfs. I recently had the pleasure to deal
with a failing disk which started to spew errors already on device
probing and it somewhat annoyed me that that slowed down boot up time
that much. Perhaps the default during device probing should be also
lower?

Adding global timeout now. Regarding the boot time exception, which version was it and do you have logs?

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux