Anton Salnikov wrote:
+static inline u32 ioread(u32 reg)
+{
+ return ioread32(base + reg);
+}
+
+static inline void iowrite(u32 val, u32 reg)
+{
+ iowrite32(val, base + reg);
+}
Why not just use ioread32/iowrite32 directly ?
Because this increases readability and does not affect functionality at all
Disagree.
It confuses the namespace, /decreasing/ readability. Anyone _but_ you
reading this code will be confused by a non-standard API named similarly
to an existing kernel API.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
