Hi, On Saturday 12 January 2008, Bartlomiej Zolnierkiewicz wrote: > On Friday 11 January 2008, Borislav Petkov wrote: > > > > Hi Bart, > > > > here's the second version of the ide-floppy refactoring trail. All the > > patches are based on the version of your quilt tree from the 05.01. Also, you've > > already applied patch 5 in this series but i'm submitting it still for the sake > > of completeness. > > > > > > drivers/ide/ide-cd.c | 2 - > > drivers/ide/ide-floppy.c | 1403 ++++++++++++++++++---------------------------- > > include/linux/cdrom.h | 1 + > > include/linux/ide.h | 3 + > > 4 files changed, 558 insertions(+), 851 deletions(-) > > applied patches #1-4, #8 > (#4 with some changes) > > #5 was already applied so I just re-ordered it into the right spot > > I have some comments for #6-7 applied #9, #15 and #17 some comments for #11-12, #14 and #18-21 in separate mails #10 and #16 are fine but because they depend on unmerged patches I'm unable to apply them currently Overall: good job! 300 LOC removed from the driver, code size savings and a lot of preparations for the future ATAPI handling unification. :) Thanks, Bart PS1 Please rebase the patches still needing polishing on top of updated IDE quilt tree, recast them and respin the patch series (no need to post already merged patches). PS2 what happend to "fix DMA error reporting" patch? (#13 is missing, hmm?) - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
