Hi, On Saturday 05 January 2008, Borislav Petkov wrote: > On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > Hi Bart, > > > Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for > > moving code out of ide-floppy.c (and this patch series doesn't change that). > ?, you mean this patch series _does_ change that, meaning it moves the struct I mean that even with this patch series applied there is no need to for header file since ide-floppy will still be the only user of it. > defs into a header file. Do i get this correctly that we don't need the header > file and the struct defs should remain in the .c file? Yes. > > Besides it would be better to just remove some structs like it has been done > > with i.e. struct atapi_capabilities_page in ide-cd.c case [1] because: > > [...] > > > typedefs are evil (exceptions are rare) and should die :) > > > > i'm redoing them right now against ide-2.6.git and will post when ready. By the ide-2.6.git is for syncing with Linus, the development tree is kept in quilt tree and is merged by Andrew to -mm. Please get the quilt patch series from: http://www.kernel.org/pub/linux/kernel/people/bart/pata-2.6/ or use the latest 2.6.24-rc6-mm1 kernel (should have most of IDE patches). > way, i have done some more cleanups in the meantime. Should i include them into > this series or send them later? Include! :) Thanks, Bart PS I still have to comment on patches #5/6/8/9. - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html