On Fri, Jan 04, 2008 at 11:49:09PM +0100, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
Hi Bart,
> Hmm, contrary to ide-cd.c case there doesn't seem to be a need currently for
> moving code out of ide-floppy.c (and this patch series doesn't change that).
?, you mean this patch series _does_ change that, meaning it moves the struct
defs into a header file. Do i get this correctly that we don't need the header
file and the struct defs should remain in the .c file?
> Besides it would be better to just remove some structs like it has been done
> with i.e. struct atapi_capabilities_page in ide-cd.c case [1] because:
[...]
> typedefs are evil (exceptions are rare) and should die :)
>
i'm redoing them right now against ide-2.6.git and will post when ready. By the
way, i have done some more cleanups in the meantime. Should i include them into
this series or send them later?
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
