On Wednesday 02 January 2008, Matt Domsch wrote: > On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > On the second thought: maybe we will be better off with limiting > > > MODULE_VERSION() to the device drivers and the IDE core module for now, > > > and just removing all these private version numbers from host drivers > > > (with one or two exceptions they are not printed or exported currently, > > > moreover exceptions are the cases like stale version numbers from 199x)? > > > > Things like checkpatch could help advise people to bump the version > > number, but it's a bit iffy. Matt D. actually uses the special source > > version modinfo for DKMS - which is different - but it makes me wonder > > whether dynamically generating a version based on source SHA1 wouldn't > > be a better idea in most cases than an outdated hard-coded one. > > We've got that already, it's called 'srcversion', and it's a CRC32 Neat. > IIRC after some limited parsing to let it ignore whitspace changes and > comment changes only. > > $ modinfo dell_rbu | grep version > version: 3.2 > srcversion: 1D4815D7D6FBEE6612F3C18 Unfortunately 'srcversion' is set only if MODULE_VERSION() is used... :( Anyway I'm dropping this patch and removing all versions from comments for now (patch #2 respin in few minutes)... Thanks, Bart - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
