On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > On the second thought: maybe we will be better off with limiting > > MODULE_VERSION() to the device drivers and the IDE core module for now, > > and just removing all these private version numbers from host drivers > > (with one or two exceptions they are not printed or exported currently, > > moreover exceptions are the cases like stale version numbers from 199x)? > > Things like checkpatch could help advise people to bump the version > number, but it's a bit iffy. Matt D. actually uses the special source > version modinfo for DKMS - which is different - but it makes me wonder > whether dynamically generating a version based on source SHA1 wouldn't > be a better idea in most cases than an outdated hard-coded one. We've got that already, it's called 'srcversion', and it's a CRC32 IIRC after some limited parsing to let it ignore whitspace changes and comment changes only. $ modinfo dell_rbu | grep version version: 3.2 srcversion: 1D4815D7D6FBEE6612F3C18 DKMS uses the srcversion if present recognize an exact match. srcversions can't be tested for anything <> though, only =. DKMS also uses the version field as supplied by MODULE_VERSION() to try to determine older-vs-newer modules. On occasion we've had to release updated "fixed" kernel modules, in which case we bump the value in MODULE_VERSION() slightly (typically append .1 or something similar) so the "fixed" module version compares higher. Such version fields aren't generally used with stock kernel.org kernels (where users can be expected to upgrade to a later stock kernel), but for users of a distro kernel where we need to fix a module without forcing the user to upgrade the whole kernel. -Matt -- Matt Domsch Linux Technology Strategist, Dell Office of the CTO linux.dell.com & www.dell.com/linux - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
