On Mon, 03 Dec 2007 13:49:36 +0900, Tejun Heo wrote: > Mikael Pettersson wrote: > >> what was the outcome of this discussion? > >> > >> I haven't looked over the Promise datasheet nor checked my brain for > >> details, hoping Mikael would do that for me ;-) > > > > I've now tested this on top of 2.6.24-rc3, with no observable > > regressions. Blanking, writing, and mounting/reading CD-RWs > > on both SATAPI and PATAPI works (tested on a 300 TX2plus card). > > > > I can't find anything in Promise's public docs or reference driver > > about non-standard requirements on lbam/lbah in ATAPI packets. > > The values set by core layer should be good enough. The only thing I'm > worried about is setting transfer chunk size when protocol is DMA. As > setting this value hasn't caused any problem for other controllers and > it seems sata_promise doesn't seem to have problem with it either, I'm > leaning toward keeping this value but if setting this value to zero is > the right thing to do, we can definitely change that in the core layer. > One way or the other, I'd really like to keep sata_promise's behavior > in line with other libata drivers. > > So, Mikael, do you think it would be okay to include the patch for > #upstream and see how it works in -mm? Yes /Mikael - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
