Re: [PATCH 14/14] libata: use PIO for misc ATAPI commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Alan Cox wrote:
>> Private command type / transfer length filtering in sata_promise,
>> pata_it821x and pata_pdc2027x are removed as core layer filtering is
>> more conservative.
>>
>> Signed-off-by: Tejun Heo <htejun@xxxxxxxxx>
> 
> NAK - as before
> 
> This is the wrong way to do stuff. Stop penalizing the 99.99% of users
> with perfectly sane hardware. In addition I note that the whitelist for
> drives would rapidly be thousands of entries long and unmanagable.

Well, I guess we'll have to agree to disagree here.  I just don't think
that penalty is worth considering and definitely don't think whitelist
is necessary at all.

> Blacklist the problem drives - there aren't that many as far as I can see
> from Fedora. Also don't confuse this with the pata_ali ATAPI problems
> which are most of the ones I do find.

If we're gonna take that road, let's lift 16 byte alignment check during
-rc cycles.  It's something which masks the problem half way.  It only
hinders the debugging process.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux