Hello. Arnd Bergmann wrote:
This driver nicely wraps around pata_platform library functions, and provides OF platform bus bindings to the PATA devices.
+static struct of_device_id pata_of_platform_match[] = { + { .compatible = "pata-platform", }, +};
"pata-platform" really means nothing outside of linux. A more generic label would be useful.
Maybe the name of the standards it supports? Could be "ata-4", "ata-5" and the like,
It's not clear what info this would provide.
or the exact transfer mode, like "pata-udma-5", "pata-pio-3", "sata-150", etc.
I think this info should follow from the compatible property value implicitly, or maybe this info should be conveyed in some optional properties. It doesn't make sense to the generic platform driver anyway since it has no notion about the mode programming specifics. I think that as the device being driven is assumed to be a generic IDE device, the "compatible" property should contain "generic" or something alike (as well as usual board's and chip's names).
Arnd <><
MBR, Sergei - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
