On 10/25/07, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > @@ -2379,9 +2379,13 @@ static int nv_init_one (struct pci_dev *
> > if (type == CK804 && adma_enabled) {
> > dev_printk(KERN_NOTICE, &pdev->dev, "Using ADMA mode\n");
> > type = ADMA;
> > + } else if (type == GENERIC && swncq_enabled) {
> > + dev_printk(KERN_NOTICE, &pdev->dev, "Using SWNCQ mode\n");
> > + type = SWNCQ;
> > }
> >
>
>
> If we want to start putting PCI_ANY_ID entries in the pci_device_id
> table (as other NVIDIA patches have proposed), I don't think it's safe
> to assume that all devices marked GENERIC can do SWNCQ, while it should
> be safe to fall back from SWNCQ to GENERIC. GENERIC is the selection
> being considered for use as being compatible with future chips.
This is up to nVidia people and may as well be dealt with in the future
patches. The only goal of this patch was to fix "a showstopper bug".
> But overall both patches look straightforward...
Thanks,
Bart
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
